v3.0.0 #252
Merged
v3.0.0 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove duplicate Region -> S3 Website URL mapping
…cations, and admin email parameter
…send sns notification)
We have customizations floated on top of swaggerUI3 that get clobbered when run npm install. Fixing it to the version that's included should prevent npm from trying to update it, and let us safely use npm install.
This change configures an origin access identity (OAI) on the CloudFront distribution and adds a policy to the S3 bucket allowing only that OAI to access the bucket contents. This means that users can no longer directly reach S3; all traffic will go through CF. This change also changes the default ACL on the files uploaded by the static-asset-uploader, because those appear to take precedence?
This change follows a few linting rules (use numbers for numbers, remove extraneous dependsOn), changes some double quotes to single quotes, and removes some unnecessary comments.
If we return a promise that doesn't fully capture the work done in non-promisified notifyCFN, the lambda runtime exits too early. If we don't return a promise, the tests don't pass. This change moves to promifisied notifyCFN so that the runtime survives until all work is done and the tests pass.
This error mapping (from 403 -> 200, serving index.html) was added so that routing to a non-existant URL (say, devportal.com/asdfasdf) would render the client-side, single-page-app's 404. Unfortunately, this breaks the logic used to detect if fetching a custom logo worked; since the status code is always 200, the client-side assumes that the logo was fetched correctly.
Fixes tab switching / first page load issues
echo-bravo-yahoo
requested review from
a-tan,
bejos-zz,
etsung-aws,
MynockSpit and
nitishdayal
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.