Fix KVSSINK State Transition Deadlock #1113
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1113 +/- ##
===========================================
+ Coverage 16.34% 16.37% +0.02%
===========================================
Files 51 51
Lines 6846 6854 +8
===========================================
+ Hits 1119 1122 +3
- Misses 5727 5732 +5 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Niyati Maheshwari <niyatim23@gmail.com>
There was a problem hiding this comment.
Tested using kvssink_gstreamer_sample to successfully ingest stream and cleanly exit upon sigint with videotestsrc, filesrc, and rtspsrc sources.
Before this change does this scenario result in an error? Do we have a situtation/test where before this change we had a deadlock and after we do not? It would be a good test case to have to make sure we do not regress in the future.
|
@hassanctech No errors from my testing, we have a customer who states they had a deadlock before implementing this change. Let's discus setting up a test, maybe based on their implementation. |
Move parent state transition to be in between upward and downward element transitions as per GStreamer documentation.
Tested using
kvssink_gstreamer_sampleto successfully ingest stream and cleanly exit upon sigint with videotestsrc, filesrc, and rtspsrc sources.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.