Merge a87b283 into 22f365e

awslabs · Dec 5, 2023 · a9c5e48 · a9c5e48
2 parents 22f365e + a87b283
commit a9c5e48
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/gstreamer/gstkvssink.cpp b/src/gstreamer/gstkvssink.cpp
@@ -1609,6 +1609,16 @@ gst_kvs_sink_change_state(GstElement *element, GstStateChange transition) {
         case GST_STATE_CHANGE_READY_TO_PAUSED:
             gst_collect_pads_start (kvssink->collect);
             break;
+        default:
+            break;
+    }
+
+    ret = GST_ELEMENT_CLASS (parent_class)->change_state(element, transition);
+    if (ret == GST_STATE_CHANGE_FAILURE) {
+        goto CleanUp;
+    }
+
+    switch (transition) {
         case GST_STATE_CHANGE_PAUSED_TO_READY:
             LOG_INFO("Stopping kvssink for " << kvssink->stream_name);
             gst_collect_pads_stop (kvssink->collect);
@@ -1631,8 +1641,6 @@ gst_kvs_sink_change_state(GstElement *element, GstStateChange transition) {
             break;
     }
 
-    ret = GST_ELEMENT_CLASS (parent_class)->change_state(element, transition);
-
 CleanUp:
 
     if (ret != GST_STATE_CHANGE_SUCCESS) {