Add HostnameImmutable context value for middleware #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
jasdel/AddHostnameImmutable
branch
2 times, most recently
from
36f7503 to
fccb102
Compare
skotambkar
reviewed
Oct 23, 2020
...rc/main/java/software/amazon/smithy/go/codegen/integration/EndpointHostPrefixMiddleware.java
Outdated
Show resolved
Hide resolved
...rc/main/java/software/amazon/smithy/go/codegen/integration/EndpointHostPrefixMiddleware.java
Show resolved
Hide resolved
...rc/main/java/software/amazon/smithy/go/codegen/integration/EndpointHostPrefixMiddleware.java
Show resolved
Hide resolved
...rc/main/java/software/amazon/smithy/go/codegen/integration/EndpointHostPrefixMiddleware.java
Show resolved
Hide resolved
...rc/main/java/software/amazon/smithy/go/codegen/integration/EndpointHostPrefixMiddleware.java
Outdated
Show resolved
Hide resolved
jasdel
force-pushed
the
jasdel/AddHostnameImmutable
branch
from
fccb102 to
7102625
Compare
skotambkar
reviewed
Oct 23, 2020
...rc/main/java/software/amazon/smithy/go/codegen/integration/EndpointHostPrefixMiddleware.java
Outdated
Show resolved
Hide resolved
...rc/main/java/software/amazon/smithy/go/codegen/integration/EndpointHostPrefixMiddleware.java
Show resolved
Hide resolved
skotambkar
approved these changes
Oct 23, 2020
...rc/main/java/software/amazon/smithy/go/codegen/integration/EndpointHostPrefixMiddleware.java
Show resolved
Hide resolved
skotambkar
reviewed
Oct 23, 2020
...rc/main/java/software/amazon/smithy/go/codegen/integration/EndpointHostPrefixMiddleware.java
Show resolved
Hide resolved
skmcgrail
approved these changes
Oct 26, 2020
Adds metadata helpers for HostnameImmutable flag, and updates endpoint prefix middleware code generation to check the flag before modifying the hostname.
jasdel
force-pushed
the
jasdel/AddHostnameImmutable
branch
from
804fb91 to
3452900
Compare
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Oct 27, 2020
…oint or not Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API. If `HostnameImmutable` is true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false. - Fixes #827 (SDK requiring region for endpoint resolution) - Fixes #328 - Fixes #364 - Related to #836 When Amazon S3 Accesspoint support is implemented. - Related to #479 Depends on aws/smithy-go#222
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Oct 27, 2020
…oint or not Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API. If `HostnameImmutable` is true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false. - Fixes #827 (SDK requiring region for endpoint resolution) - Fixes #328 - Fixes #364 - Related to #836 When Amazon S3 Accesspoint support is implemented. - Related to #479 Depends on aws/smithy-go#222
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Oct 27, 2020
Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API. If `HostnameImmutable` is true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false. - Fixes #827 (SDK requiring region for endpoint resolution) - Fixes #328 - Fixes #364 - Related to #836 When Amazon S3 Accesspoint support is implemented. - Related to #479 Depends on aws/smithy-go#222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
HostnameImmutablecontext value getter/setter helpers totransport/httppackage.Updates EndpointTrait's HostPrefix handling to use the HostnameImmutable to skip modifying the endpoint.
Also refactors EndpointTrait HostPrefix handling to be an integration instead of implemented directly in the operation serializer.