Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making API operation call without configured AWS region results in odd error. #827

Closed
3 tasks done
jasdel opened this issue Oct 15, 2020 · 0 comments · Fixed by #848
Closed
3 tasks done

Making API operation call without configured AWS region results in odd error. #827

jasdel opened this issue Oct 15, 2020 · 0 comments · Fixed by #848
Labels
bug This issue is a bug.

Comments

@jasdel
Copy link
Contributor

jasdel commented Oct 15, 2020 •
edited
Loading

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug
Making an API operation call with a client that does not have a Region value configured results in an error because DNS lookup fails. The SDK should require the Region configuration, and return an error when the endpoint resolver does not receive an Region.

Version of AWS SDK for Go?
v0.26.0

Version of Go (go version)?
go 1.15.2

To Reproduce (observed behavior)
Steps to reproduce the behavior (please share code or minimal repo)

Expected behavior
Call API operation with a client that is not configured for a region.

Additional context

2020/10/15 16:00:20 operation error DynamoDB: Scan, exceeded maximum number of attempts, 3, https response error StatusCode: 0, RequsetID: , request send failed, Post "https://dynamodb..amazonaws.com/": dial tcp: lookup dynamodb..amazonaws.com: no such host
@jasdel jasdel added the bug This issue is a bug. label Oct 15, 2020
@jasdel jasdel mentioned this issue Oct 21, 2020
Merged
jasdel added a commit that referenced this issue Oct 27, 2020
@jasdel
codegen: Add flag to direct if SDK is allowed to modify a custom endp…
a2a0b11 
…oint or not

Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member
directs if the SDK is allowed to modify the resolved endpoint to meet the
requirements of the API.  If `HostnameImmutable` is true, the SDK will not
attempt to modify the hostname via any customizations, or prefix behavior. Flag
 defaults to false.

- Fixes #827 (SDK requiring region for endpoint resolution)
- Fixes #328
- Fixes #364
- Related to #836 When Amazon S3 Accesspoint support is implemented.
- Related to #479

Depends on aws/smithy-go#222
jasdel added a commit that referenced this issue Oct 27, 2020
@jasdel
codegen: Add flag to direct if SDK is allowed to modify a custom endp…
2592e95 
…oint or not

Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member
directs if the SDK is allowed to modify the resolved endpoint to meet the
requirements of the API.  If `HostnameImmutable` is true, the SDK will not
attempt to modify the hostname via any customizations, or prefix behavior. Flag
 defaults to false.

- Fixes #827 (SDK requiring region for endpoint resolution)
- Fixes #328
- Fixes #364
- Related to #836 When Amazon S3 Accesspoint support is implemented.
- Related to #479

Depends on aws/smithy-go#222
jasdel added a commit that referenced this issue Oct 27, 2020
@jasdel
Merge pull request #848 from aws/jasdel/cust/EndpointResolver
6ecaaba 
Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API.  If `HostnameImmutable` is true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false.

- Fixes #827 (SDK requiring region for endpoint resolution)
- Fixes #328
- Fixes #364
- Related to #836 When Amazon S3 Accesspoint support is implemented.
- Related to #479

Depends on aws/smithy-go#222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

codegen: Add flag to direct if SDK is allowed to modify a custom endpoint or not aws/aws-sdk-go-v2
1 participant
@jasdel