-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ML-KEM Feature Probe and Test #4823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to confirm that S2N_LIBCRYPTO_SUPPORTS_MLKEM is true for at least a subset of the CI (and at least one asan or valgrind test) before merging this.
08e7a8e
to
f3e8f82
Compare
f3e8f82
to
59554b6
Compare
The |
Resolved issues:
N/A
Description of changes:
Part 2 in a multi-part series to add
X25519MLKEM768
support to s2n. This PR adds a LibCrypto feature probe for ML-KEM Support, and unit test that confirms feature probe works as expected.Call-outs:
Previous PR's must be merged first:
Testing:
Tested locally against AWS-LC built from the tip of their main branch.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.