Add initial support for MLKEM768 (without any new Security Policies) #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexw91
changed the title
alexw91
force-pushed
the
mlkem-part-2
branch
2 times, most recently
from
316df93 to
19fcae8
Compare
alexw91
changed the title
alexw91
force-pushed
the
mlkem-part-2
branch
3 times, most recently
from
a4cf925 to
d07f333
Compare
lrstewart
reviewed
Oct 3, 2024
alexw91
force-pushed
the
mlkem-part-2
branch
5 times, most recently
from
a592e1e to
90ec719
Compare
goatgoose
reviewed
Oct 4, 2024
goatgoose
reviewed
Oct 4, 2024
alexw91
force-pushed
the
mlkem-part-2
branch
3 times, most recently
from
8e227ab to
128df67
Compare
This was referenced Oct 8, 2024
goatgoose
approved these changes
Oct 9, 2024
goatgoose
approved these changes
Oct 10, 2024
lrstewart
reviewed
Oct 10, 2024
Comment on lines
16
to
20
| #include "crypto/s2n_libcrypto.h" | ||
| #include "s2n_test.h" | ||
| #include "testlib/s2n_testlib.h" | ||
|
|
||
| bool s2n_libcrypto_supports_flag_no_check_time(); | ||
| uint64_t s2n_libcrypto_awslc_api_version(void); |
There was a problem hiding this comment.
How is this change related to the rest of this PR?
There was a problem hiding this comment.
It's not, this change is a cleanup that probably should have been included in the previous PR. This is the only other use of s2n_libcrypto_awslc_api_version() in the s2n unit tests. Now that this API was added to s2n_libcrypto.h I updated this test to include the header instead of declaring the API itself.
lrstewart
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
None
Note: PR #4823 should be reviewed and merged before this PR.
Description of changes:
Part 3 in a multi-part series to add
X25519MLKEM768support to s2n.This PR includes the following changes:
send_kem_firstboolean parameter for Hybrid PQ KeyShares (needed forX25519MLKEM768).MLKEM768X25519MLKEM768andSecP256r1MLKEM768X25519MLKEM768and confirm shared secret calculation is correct.Call-outs:
No new s2n-tls security policies with
X25519MLKEM768have been added (other thantest_allPolicy). These new MLKEM-768 security policies will be coming in a later PR.Previous PR's must be merged first:
Testing:
X25519MLKEM768Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.