chore: bump awslc(non FIPS) to 1.36.0 #4821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
approved these changes
Oct 4, 2024
dougch
force-pushed
the
awslc_ver_bump_136
branch
from
c0030c6 to
0144f17
Compare
alexw91
approved these changes
Oct 7, 2024
jouho
approved these changes
Oct 7, 2024
|
AWSLC 1.36.0 is compiled with Clang in docker images for Ubuntu 22 and 24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We pin the aws-lc version in two places; bump it to almost latest.
Call-outs:
The 1.36.1 release contains a pkg-config change that breaks nix.
There is a small write-up about how to handle path concatenation: https://github.com/jtojnar/cmake-snips/#concatenating-paths-when-building-pkg-config-files , I'll cut an aws-lc issue when I better understand this.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? localy
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.