chore: fix CBMC proof summary count #4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had an off-by-one error in the summary of the CBMC job, claiming one proof more as successful than we actually had proofs.
|
Many thanks for the fix. I assume one of the s2n-tls developers can approve and merge this. |
camshaft
approved these changes
Jun 25, 2024
lrstewart
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We had an off-by-one error in the summary of the CBMC job, claiming one proof more as successful than we actually had proofs. Issue found by @rod-chapman.
Testing:
Tested in CI (the expected number of successful proofs is in s2n-tls 163). See "Summary" page of https://github.com/aws/s2n-tls/actions/runs/9660332387?pr=4627.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.