Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbmc-viewer reports wrong count of successul proofs #152

Closed
rod-chapman opened this issue Jun 20, 2024 · 2 comments
Closed

cbmc-viewer reports wrong count of successul proofs #152

rod-chapman opened this issue Jun 20, 2024 · 2 comments

Comments

@rod-chapman
Copy link

Re-running the verification of mlkem-c-aarch64 using the new CBMC 6.0.0 release, using the
"run-cbmc-proofs.py" scripts, the output ends with:

| Status  | Count |
|---------|-------|
| Success | 7     |

| Proof                  | Status  |
|------------------------|---------|
| poly_compress          | Success |
| poly_decompress        | Success |
| scalar_compress_q_16   | Success |
| scalar_compress_q_32   | Success |
| scalar_decompress_q_16 | Success |
| scalar_decompress_q_32 | Success |

It says "7" Successes, but then only lists 6 functions in the table below. I have seen the same discrepency in the proof of s2n-tls. Is this a bug?

@rod-chapman
Copy link
Author

If I deliberately break one of the proofs so it fails, then I get

## Summary of CBMC proof results

| Status  | Count |
|---------|-------|
| Fail    | 2     |
| Success | 5     |

| Proof                  | Status  |
|------------------------|---------|
| scalar_compress_q_16   | Fail    |
| scalar_decompress_q_16 | Fail    |
| poly_compress          | Success |
| poly_decompress        | Success |
| scalar_compress_q_32   | Success |
| scalar_decompress_q_32 | Success |

The "Success" count is always 1 too large.

@tautschnig
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants