fix: init implicit iv for serialization feature #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
May 24, 2024
camshaft
approved these changes
May 24, 2024
lrstewart
reviewed
May 24, 2024
lrstewart
reviewed
May 24, 2024
camshaft
reviewed
May 25, 2024
lrstewart
reviewed
May 28, 2024
maddeleine
changed the title
lrstewart
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A
Description of changes:
The s2n-tls serialization feature doesn't work when s2n-tls is built with AWS-LC or boringssl. The reason is that they assume that the first sequence number to be seen after init is 0, which means that the nonce we provide can be considered the implicit IV. This implicit IV is used to ensure the monotonicity of sequence numbers in the future. Serialization breaks this assumption because after deserialization the sequence number may not be 0, which means that AWS-LC will store the wrong implicit IV.
Therefore this change does a throwaway encrypt call right after deserialization to allow AWS-LC to store the correct implicit IV.
Call-outs:
I also included a code change to close the connection after serializing, as we really don't want people to serialize and continue to use the connection.
Testing:
Increased the number of times we encrypt/decrypt after serialization in the tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.