Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS-LC/BoringSSL macros and trycompiles can probably be cleaned up #4575

Closed
maddeleine opened this issue May 29, 2024 · 0 comments · Fixed by #4642
Closed

AWS-LC/BoringSSL macros and trycompiles can probably be cleaned up #4575

maddeleine opened this issue May 29, 2024 · 0 comments · Fixed by #4642

Comments

@maddeleine
Copy link
Contributor

Security issue notifications

If you discover a potential security issue in s2n we ask that you notify
AWS Security via our vulnerability reporting page. Please do not create a public github issue.

Problem:

#4572 introduced the try-compile s2n_libcrypto_supports_evp_aead_tls. This is probably the same thing as our macro S2N_AEAD_AES_GCM_AVAILABLE and potentially can be merged together, but its sort of unknown how large this change is. We have to look carefully at our macros to make sure they all mean the same thing.

Solution:

Look through the code and see where #if defined(OPENSSL_IS_BORINGSSL) || defined(OPENSSL_IS_AWSLC) is used. If it's code thats being used to gate aead logic, we can probably clean this all up to use only the libcrypto_supports macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants