Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport consume log path values (#6875) #6994

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Sep 12, 2024

Fixes #N/A

Description
Backports logOutputPath and logErrorOutputPath fixes.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner September 12, 2024 18:21
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10836506573

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 79.327%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
Totals Coverage Status
Change from base Build 10782689309: -0.01%
Covered Lines: 5921
Relevant Lines: 7464

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit 79cc71d into aws:release-v1.0.x Sep 12, 2024
12 checks passed
@rschalo rschalo deleted the backport-log-path branch September 12, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants