Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consume log path values #6875

Merged
merged 6 commits into from
Aug 26, 2024
Merged

fix: consume log path values #6875

merged 6 commits into from
Aug 26, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Aug 26, 2024

Fixes kubernetes-sigs/karpenter#1572

Description
Bug fix for not referencing log output paths.

How was this change tested?
make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit ffc9404
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66ccf4e5c32f53000832e0b0
😎 Deploy Preview https://deploy-preview-6875--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Aug 26, 2024

Pull Request Test Coverage Report for Build 10567644204

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.311%

Totals Coverage Status
Change from base Build 10564776335: 0.0%
Covered Lines: 5938
Relevant Lines: 7487

💛 - Coveralls

@rschalo rschalo marked this pull request as ready for review August 26, 2024 21:18
@rschalo rschalo requested a review from a team as a code owner August 26, 2024 21:18
@rschalo rschalo requested a review from jigisha620 August 26, 2024 21:18
@rschalo rschalo enabled auto-merge (squash) August 26, 2024 21:35
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit 3ea5fef into aws:main Aug 26, 2024
15 checks passed
@rschalo rschalo deleted the fix-log-paths branch August 26, 2024 22:04
@rschalo rschalo changed the title Fix log paths fix: consume log path values Aug 27, 2024
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logOutputPaths and logErrorOutputPaths not working
3 participants