Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(merge-back): v1.86.1 #4210

Merged
merged 7 commits into from
Aug 4, 2023
Merged

chore(merge-back): v1.86.1 #4210

merged 7 commits into from
Aug 4, 2023

Conversation

RomainMuller
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

RomainMuller and others added 7 commits August 2, 2023 15:52
The registration was done on the object's prototype, and tthe value from
the constructor was always used, even if that was inherited, such that
if a parent type ahd already been resolved previously, all child types
would use the parent's FQN instead of their own.

Addressed this by instead storing the associations in an external
WeakMap, and added a test case to validate correct behavior.

Fixes aws/aws-cdk#26604
…y installed in superchain (#4201)

The packages were installed in a virtual environment, which is not subsequently re-activated in the image's ENTRYPOINT. Instead, install the packages 'globally'
3.9.3 was pulled from the distribution point.
@RomainMuller RomainMuller added the pr/no-squash This PR should be merged instead of squash-merging it label Aug 4, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 4, 2023
@RomainMuller RomainMuller merged commit 5ebb43b into main Aug 4, 2023
22 checks passed
@RomainMuller RomainMuller deleted the merge-back branch August 4, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant