Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): v1.86.1 #4206

Merged
merged 2 commits into from
Aug 2, 2023
Merged

chore(release): v1.86.1 #4206

merged 2 commits into from
Aug 2, 2023

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Aug 2, 2023

See CHANGELOG.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The registration was done on the object's prototype, and tthe value from
the constructor was always used, even if that was inherited, such that
if a parent type ahd already been resolved previously, all child types
would use the parent's FQN instead of their own.

Addressed this by instead storing the associations in an external
WeakMap, and added a test case to validate correct behavior.

Fixes aws/aws-cdk#26604
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 2, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2023

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@RomainMuller RomainMuller changed the title release: v1.86.1 chore(release): v1.86.1 Aug 2, 2023
@RomainMuller RomainMuller merged commit defb235 into release Aug 2, 2023
18 of 21 checks passed
@RomainMuller RomainMuller deleted the rmuller/patch branch August 2, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant