-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use roles to get access key details in build spec #9430
Conversation
/hold |
Adding hold until below changes are merged and deployed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9430 +/- ##
==========================================
+ Coverage 69.45% 69.47% +0.02%
==========================================
Files 672 672
Lines 49357 49381 +24
==========================================
+ Hits 34280 34307 +27
+ Misses 13290 13288 -2
+ Partials 1787 1786 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0b3ab77
to
35f3d55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vivek-koppuru The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.22 |
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.22 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.21 |
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unhold |
@sp1999: new pull request created: #9471 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sp1999: new pull request created: #9472 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
#9178
Description of changes:
Updating code build spec to use role for fetching aws credentials and setting them as environment variables.
Testing (if applicable):
Tested the logic of getting credentials by running an code build with override.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.