Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use session token in aws authentication #9419

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

rajeshvenkata
Copy link
Member

Issue #, if available:
https://github.com/aws/eks-anywhere-internal/issues/2650
#9177

Description of changes:
As part of migrating from using long term credentials in e2e test, I am making changes here to use session token and propogate it to secrets which will be used by curated packages.

Testing (if applicable):
Created a cluster and verified that secrets created has the session token if available. Tested the normal case where there is no session token

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.47%. Comparing base (cd28200) to head (c7ecde7).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
pkg/curatedpackages/regional_registry.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9419      +/-   ##
==========================================
+ Coverage   69.45%   69.47%   +0.02%     
==========================================
  Files         672      672              
  Lines       49357    49381      +24     
==========================================
+ Hits        34280    34307      +27     
+ Misses      13290    13288       -2     
+ Partials     1787     1786       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rajeshvenkata rajeshvenkata force-pushed the use-sessiontoken branch 3 times, most recently from 13c9758 to 52d677d Compare March 14, 2025 20:47
@vivek-koppuru
Copy link
Member

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vivek-koppuru

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit a87378e into aws:main Mar 21, 2025
12 checks passed
@sp1999
Copy link
Member

sp1999 commented Mar 22, 2025

/cherry-pick release-0.22

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #9467

In response to this:

/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member

sp1999 commented Mar 22, 2025

/cherry-pick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #9468

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants