tweak docker desktop validation check for newer versions #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
approved
size/L
mdsgabriel
approved these changes
Jan 24, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaxesn, mdsgabriel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Per #789 we added a validation for docker desktop on mac to ensure the user has a version < 4.3.0. Docker recently released 4.4.2 which added an option to revert back to cgroupv1 for users using older container images without support for cgroup v2 (which our Kind image is one). From their changelog:
Added a deprecated option to settings.json: "deprecatedCgroupv1": true, which switches the Linux environment back to cgroups v1. If your software requires cgroups v1, you should update it to be compatible with cgroups v2. Although cgroups v1 should continue to work, it is likely that some future features will depend on cgroups v2. It is also possible that some Linux kernel bugs will only be fixed with cgroups v2.This tweaks the validation to allow 4.4.2+ with the deprecatedCgroupsv1 set to true through the validation. I validated this on my Mac with the 4.4.2 release of Docker Desktop and the bootstrap cluster created just fine. I used the script from here to set the setting and intend to update our docs to have something similar.
It would be helpful for others to try upgrading and validating this as well.
Note: If/when we upgrade to al2022 for our base images, including Kind, well be able to remove the v1 requirement since it includes a newer version of systemd which supports v2. There is a WIP PR adding al2022 based images to the build process.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.