Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): skip emitting warning for Node.js 14.x #6044

Merged
merged 1 commit into from
May 1, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 1, 2024

Issue

Internal JS-5174

Support for Node.js 14.x ended in #6034

Description

Skip emitting warning for Node.js 14.x

Testing

Build client-dynamodb in aws-sdk-js-v3

$ client-dynamodb> yarn build:include:deps

Prepare test file in test package

$> echo 'import { DynamoDB } from "../aws-sdk-js-v3/clients/client-dynamodb/dist-cjs/index.js"; const client = new DynamoDB();' > index.mjs

Before

$> node -v
v14.21.3

$> node index.mjs
(node:38205) Warning: NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
no longer support Node.js 14.x on May 1, 2024.

To continue receiving updates to AWS services, bug fixes, and security
updates please upgrade to an active Node.js LTS version.

More information can be found at: https://a.co/dzr2AJd
(Use `node --trace-warnings ...` to show where the warning was created)

After

No warning is emitted.
No error is thrown during client creation, as we don't use Node.js 16.x specific API or specification.

$> node -v
v14.21.3

$> node index.mjs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review May 1, 2024 16:47
@trivikr trivikr requested a review from a team as a code owner May 1, 2024 16:47
@trivikr trivikr merged commit 669a7de into aws:main May 1, 2024
5 checks passed
@trivikr trivikr deleted the comment-deprecation-msg branch May 1, 2024 16:58
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants