chore(core): skip emitting warning for Node.js 14.x (#6044)

aws · May 1, 2024 · 669a7de · 669a7de
1 parent 306aafc
commit 669a7de
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/packages/core/src/client/emitWarningIfUnsupportedVersion.spec.ts b/packages/core/src/client/emitWarningIfUnsupportedVersion.spec.ts
@@ -14,7 +14,7 @@ describe("emitWarningIfUnsupportedVersion", () => {
     process.emitWarning = emitWarning;
   });
 
-  describe(`emits warning for Node.js <${supportedVersion}`, () => {
+  describe.skip(`emits warning for Node.js <${supportedVersion}`, () => {
     const getPreviousMajorVersion = (major: number) => (major === 0 ? 0 : major - 1);
 
     const getPreviousMinorVersion = ([major, minor]: [number, number]) =>

diff --git a/packages/core/src/client/emitWarningIfUnsupportedVersion.ts b/packages/core/src/client/emitWarningIfUnsupportedVersion.ts
@@ -12,14 +12,15 @@ let warningEmitted = false;
 export const emitWarningIfUnsupportedVersion = (version: string) => {
   if (version && !warningEmitted && parseInt(version.substring(1, version.indexOf("."))) < 16) {
     warningEmitted = true;
-    process.emitWarning(
-      `NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
-no longer support Node.js 14.x on May 1, 2024.
+    // ToDo: Turn back warning for future Node.js version deprecation
+    //     process.emitWarning(
+    //       `NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
+    // no longer support Node.js 14.x on May 1, 2024.
 
-To continue receiving updates to AWS services, bug fixes, and security
-updates please upgrade to an active Node.js LTS version.
+    // To continue receiving updates to AWS services, bug fixes, and security
+    // updates please upgrade to an active Node.js LTS version.
 
-More information can be found at: https://a.co/dzr2AJd`
-    );
+    // More information can be found at: https://a.co/dzr2AJd`
+    //     );
   }
 };