Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client-cognito-identity): remove auth customizations #1733

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,7 @@ public List<RuntimeClientPlugin> getClientPlugins() {
.withConventions(AwsDependency.MIDDLEWARE_SIGNING.dependency, "AwsAuth", HAS_MIDDLEWARE)
// See operationUsesAwsAuth() below for AwsAuth Middleware customizations.
.servicePredicate(
(m, s) ->
!testServiceId(s, "Cognito Identity")
&& !testServiceId(s, "STS")
&& !hasOptionalAuthOperation(m, s)
(m, s) -> !testServiceId(s, "STS") && !hasOptionalAuthOperation(m, s)
).build(),
RuntimeClientPlugin.builder()
.withConventions(TypeScriptDependency.MIDDLEWARE_RETRY.dependency, "Retry")
Expand Down Expand Up @@ -169,15 +166,6 @@ private static boolean testServiceId(Shape serviceShape, String expectedId) {
}

private static boolean operationUsesAwsAuth(Model model, ServiceShape service, OperationShape operation) {
// Cognito Identity doesn't need auth for GetId, GetOpenIdToken, GetCredentialsForIdentity, UnlinkIdentity.
// Remove when optionalAuth model update is published in V261331976.
if (testServiceId(service, "Cognito Identity")) {
Boolean isUnsignedCommand = SetUtils
.of("GetId", "GetOpenIdToken", "GetCredentialsForIdentity", "UnlinkIdentity")
.contains(operation.getId().getName());
return !isUnsignedCommand;
}

// STS doesn't need auth for AssumeRoleWithWebIdentity, AssumeRoleWithSAML.
// Remove when optionalAuth model update is published in 0533102932.
if (testServiceId(service, "STS")) {
Expand Down