Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client-cognito-identity): remove auth customizations #1733

Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Dec 1, 2020

Issue #, if available:
Refs: aws/aws-sdk-js#3543

Description of changes:
The customization is no longer required as smithy optionalAuth was added to respective APIs in 11/20 models update.

Verified that running codegen doesn't update the client-cognito-identity:

$ yarn generate-clients -g codegen/sdk-codegen/aws-models/cognito-identity.2014-06-30.json

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from AllanZhengYP December 1, 2020 01:08
@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #1733 (b93d259) into master (de75f7e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
- Coverage   79.77%   79.77%   -0.01%     
==========================================
  Files         325      329       +4     
  Lines       12087    12583     +496     
  Branches     2553     2675     +122     
==========================================
+ Hits         9643    10038     +395     
- Misses       2444     2545     +101     
Impacted Files Coverage Δ
...tocol_tests/aws-restxml/commands/XmlMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...col_tests/aws-restjson/commands/JsonMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlAttributesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlNamespacesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc692e...b93d259. Read the comment docs.

@trivikr trivikr changed the title chore(client-cognito-identity): remove disable auth customizations chore(client-cognito-identity): remove auth customizations Dec 1, 2020
@trivikr trivikr merged commit 11bc793 into aws:master Dec 1, 2020
@trivikr trivikr deleted the remove-cognitoidentity-auth-customization branch December 1, 2020 17:32
@github-actions
Copy link

github-actions bot commented Jan 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants