Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert RESTJSON and RESTXML changes of SDK v1.11.0 #1551

Merged
merged 2 commits into from
Sep 26, 2017
Merged

Revert RESTJSON and RESTXML changes of SDK v1.11.0 #1551

merged 2 commits into from
Sep 26, 2017

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Sep 26, 2017 •
edited
Loading

Bug discovered in RESTXML protocol marshaler that did not correctly marshal some of the Route53's due to the locationName tag wrapping the request parameters. This only impacted Route53 API operations.

Related to #1550

@jasdel
Revert "API Marshaler: Add generated marshalers for RESTJSON protocol (…
c7b79f6 
…aws#1547)"

This reverts commit 1a10a10.

Reverts RESTJSON marshaler improvement due to bug in RESTXML
@jasdel
Revert "API Marshaling: Add generated marshalers for RESTXML protocol (…
e7dcfd5 
…aws#1409)"

This reverts commit 37448a9.

Reverts RESTXML due to aws#1550
@jasdel jasdel self-assigned this Sep 26, 2017
@jasdel jasdel requested a review from xibz September 26, 2017 22:03
@jasdel jasdel mentioned this pull request Sep 26, 2017
Closed
@jasdel jasdel merged commit 6a946b2 into aws:master Sep 26, 2017
@jasdel jasdel deleted the revert/SDKv1.11 branch September 26, 2017 22:35
jasdel added a commit to jasdel/aws-sdk-go that referenced this pull request Sep 27, 2017
@jasdel
Revert "Revert RESTJSON and RESTXML changes of SDK v1.11.0 (aws#1551)"
353e416 
This reverts commit 6a946b2.

Fixes the aws#1550 bug with RESTXML not correctly marshaling Amazon Route53 APIs
jasdel added a commit to jasdel/aws-sdk-go that referenced this pull request Sep 28, 2017
@jasdel
Revert "Revert RESTJSON and RESTXML changes of SDK v1.11.0 (aws#1551)"
638b3af 
This reverts commit 6a946b2.

Fixes the aws#1550 bug with RESTXML not correctly marshaling Amazon Route53 APIs
jasdel added a commit to jasdel/aws-sdk-go that referenced this pull request Nov 17, 2017
@jasdel
Revert "Revert RESTJSON and RESTXML changes of SDK v1.11.0 (aws#1551)"
44b9a97 
This reverts commit 6a946b2.

Fixes the aws#1550 bug with RESTXML not correctly marshaling Amazon Route53 APIs
jasdel added a commit to jasdel/aws-sdk-go that referenced this pull request Nov 27, 2017
@jasdel
Revert "Revert RESTJSON and RESTXML changes of SDK v1.11.0 (aws#1551)"
7a80f55 
This reverts commit 6a946b2.

Fixes the aws#1550 bug with RESTXML not correctly marshaling Amazon Route53 APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xibz xibz xibz approved these changes

Assignees

@jasdel jasdel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasdel @xibz