API Marshaler: Add generated marshalers for RESTJSON protocol #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the RESTJSON protocol marshalers to use code generation instead of reflection based marshaling. These changes improve the performance of the SDK's marshaling in both time (CPU), number and size of allocations. The following benchmark shows a relative difference between the SDKs previous marshaling of RESTJSON performance and the performance with the generated marshaling. ``` benchmark old ns/op new ns/op delta BenchmarkRESTJSONBuild_Complex_ETCCreateJob-4 105896 36199 -65.82% BenchmarkRESTJSONBuild_Simple_ETCListJobsByPipeline-4 8246 5085 -38.33% BenchmarkRESTJSONRequest_Complex_CFCreateJob-4 318451 215346 -32.38% BenchmarkRESTJSONRequest_Simple_ETCListJobsByPipeline-4 133614 126604 -5.25% benchmark old allocs new allocs delta BenchmarkRESTJSONBuild_Complex_ETCCreateJob-4 327 239 -26.91% BenchmarkRESTJSONBuild_Simple_ETCListJobsByPipeline-4 67 50 -25.37% BenchmarkRESTJSONRequest_Complex_CFCreateJob-4 686 598 -12.83% BenchmarkRESTJSONRequest_Simple_ETCListJobsByPipeline-4 245 228 -6.94% benchmark old bytes new bytes delta BenchmarkRESTJSONBuild_Complex_ETCCreateJob-4 24112 19992 -17.09% BenchmarkRESTJSONBuild_Simple_ETCListJobsByPipeline-4 3728 3765 +0.99% BenchmarkRESTJSONRequest_Complex_CFCreateJob-4 74537 70378 -5.58% BenchmarkRESTJSONRequest_Simple_ETCListJobsByPipeline-4 49721 49764 +0.09% ```
jasdel
force-pushed
the
feature/RESTJSONGenMarshalers
branch
from
f54b9aa
to
d080fad
Compare
xibz
approved these changes
Sep 25, 2017
Merged
jasdel
added a commit
that referenced
this pull request
Sep 26, 2017
* Revert "API Marshaler: Add generated marshalers for RESTJSON protocol (#1547)" This reverts commit 1a10a10. Reverts RESTJSON marshaler improvement due to bug in RESTXML * Revert "API Marshaling: Add generated marshalers for RESTXML protocol (#1409)" This reverts commit 37448a9. Reverts RESTXML due to #1550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the RESTJSON protocol marshalers to use code generation instead
of reflection based marshaling. These changes improve the performance of
the SDK's marshaling in both time (CPU), number and size of allocations.
The following benchmark shows a relative difference between the SDKs
previous marshaling of RESTJSON performance and the performance with the
generated marshaling.