fix(tree): use decltype instead of typeof for cxx #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
aws-nslick/stack/12
branch
from
ca635a9 to
c43056b
Compare
ghost
force-pushed
the
aws-nslick/stack/11
branch
from
b9dc38e to
a65a011
Compare
This was referenced Sep 4, 2024
ghost
force-pushed
the
aws-nslick/stack/12
branch
from
c43056b to
d95a152
Compare
ghost
force-pushed
the
aws-nslick/stack/12
branch
from
d95a152 to
a366b31
Compare
ghost
force-pushed
the
aws-nslick/stack/12
branch
from
a366b31 to
743e062
Compare
ghost
changed the title
ghost
mentioned this pull request
Merged
This was referenced Sep 12, 2024
This was referenced Sep 12, 2024
ghost
force-pushed
the
aws-nslick/stack/12
branch
from
65ca1ec to
24c4ee0
Compare
ghost
force-pushed
the
aws-nslick/stack/12
branch
from
24c4ee0 to
dac63ae
Compare
stack-info: PR: #565, branch: aws-nslick/stack/12 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
ghost
force-pushed
the
aws-nslick/stack/12
branch
from
dac63ae to
93206c3
Compare
ghost
changed the title
bwbarrett
reviewed
Sep 24, 2024
bwbarrett
approved these changes
Sep 26, 2024
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Oct 1, 2024
typeof stopped working in newer GCC when in cxx mode. __typeof__ works in all cases and is the preferred solution for doing this portably. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
typeof stopped working in newer GCC when in cxx mode. __typeof__ works in all cases and is the preferred solution for doing this portably. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
fix(tree): use decltype instead of typeof for cxx
Signed-off-by: Nicholas Sielicki nslick@amazon.com