feat(tree): add static_assert shim macro #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
aws-nslick/stack/2
branch
from
f113230 to
f57f3da
Compare
ghost
force-pushed
the
aws-nslick/stack/3
branch
from
556e4e9 to
629605f
Compare
This was referenced Sep 4, 2024
bwbarrett
previously requested changes
Sep 4, 2024
ghost
force-pushed
the
aws-nslick/stack/3
branch
from
629605f to
16fab3b
Compare
ghost
force-pushed
the
aws-nslick/stack/3
branch
from
16fab3b to
af6fa53
Compare
ghost
force-pushed
the
aws-nslick/stack/3
branch
from
af6fa53 to
7f38e65
Compare
ghost
changed the title
ghost
force-pushed
the
aws-nslick/stack/3
branch
from
7f38e65 to
ce2837b
Compare
ghost
mentioned this pull request
rauteric
previously approved these changes
Sep 5, 2024
|
bot:aws:retest |
ghost
force-pushed
the
aws-nslick/stack/2
branch
from
cf92a28 to
0a16b1f
Compare
ghost
force-pushed
the
aws-nslick/stack/3
branch
from
ce2837b to
2fa58cf
Compare
rauteric
previously approved these changes
Sep 6, 2024
|
bot:aws:retest |
static_assert is a c++ keyword, so when not using c++, create a macro under the same name that aliases _Static_assert to static_assert. This means static_assert can be used in both cases. stack-info: PR: #556, branch: aws-nslick/stack/3 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
ghost
force-pushed
the
aws-nslick/stack/3
branch
from
2fa58cf to
41dd554
Compare
|
bot:aws:retest |
rauteric
approved these changes
Sep 9, 2024
|
Commit previously passed without modifications. |
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
static_assert is a c++ keyword, so when not using c++, create a macro under the same name that aliases _Static_assert to static_assert. This means static_assert can be used in both cases. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
-Wc++-compat' with-x c++' #578feat(tree): add static_assert shim macro
static_assert is a c++ keyword, so when not using c++, create a macro
under the same name that aliases _Static_assert to static_assert. This
means static_assert can be used in both cases.
Signed-off-by: Nicholas Sielicki nslick@amazon.com