Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt to chmod aws binary even if it's already world-executable #66

Closed
jaypipes opened this issue Dec 23, 2019 · 0 comments
Closed

attempt to chmod aws binary even if it's already world-executable #66

jaypipes opened this issue Dec 23, 2019 · 0 comments

Comments

@jaypipes
Copy link
Contributor

ref: aws/amazon-vpc-cni-k8s#770

We want to use an updated aws-k8s-tester binary (UpdateFromEnv was added in 0.5.1) but unfortunately v0.5.1 fails for me because it attempts to chmod the aws CLI:

failed to create EKS deployer error doing chmod on "/usr/local/bin/aws": chmod /usr/local/bin/aws: operation not permitted

Note that I have the aws binary already installed and is world-executable:

jaypipes@thelio:~/go/src/github.com/aws/amazon-vpc-cni-k8s$ ls -l `which aws`
-rwxr-xr-x 1 root root 815 Jun 28 10:25 /usr/local/bin/aws

so I'm not sure why aws-k8s-tester is trying to chmod anything.
@jaypipes jaypipes changed the title attempt to chmod aws binary even if it's already world-readable attempt to chmod aws binary even if it's already world-executable Dec 23, 2019
jaypipes added a commit to jaypipes/aws-k8s-tester that referenced this issue Dec 23, 2019
@jaypipes
Only attempt chmod of aws CLI if not executable
c640b28 
Adds a file stat check to ensure we only attempt to do a chmod on the
`aws` CLI executable if it does not already have execute permissions.

Closes Issue aws#66
@jaypipes jaypipes mentioned this issue Dec 23, 2019
Merged
jaypipes added a commit to jaypipes/amazon-vpc-cni-k8s that referenced this issue Jan 3, 2020
@jaypipes
do pre-checks before creating EKS test cluster
227e9fc 
Ensure that there is an ECR repo before we use aws-k8s-tester to actually
create the test cluster. In addition, trap errors in the main
run-integration-tests.sh script and deprovision cluster if an error
occurred after creating the cluster.

Updates the required aws-k8s-tester release to 0.5.2 to handle
aws/aws-k8s-tester#66

Issue aws#765
mogren pushed a commit to aws/amazon-vpc-cni-k8s that referenced this issue Jan 20, 2020
@jaypipes @mogren
do pre-checks before creating EKS test cluster
45a3719 
Ensure that there is an ECR repo before we use aws-k8s-tester to actually
create the test cluster. In addition, trap errors in the main
run-integration-tests.sh script and deprovision cluster if an error
occurred after creating the cluster.

Updates the required aws-k8s-tester release to 0.5.2 to handle
aws/aws-k8s-tester#66

Issue #765
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Jan 31, 2020
@jaypipes
do pre-checks before creating EKS test cluster
abba8d2 
Ensure that there is an ECR repo before we use aws-k8s-tester to actually
create the test cluster. In addition, trap errors in the main
run-integration-tests.sh script and deprovision cluster if an error
occurred after creating the cluster.

Updates the required aws-k8s-tester release to 0.5.2 to handle
aws/aws-k8s-tester#66

Issue aws#765

(cherry picked from commit 45a3719)
jaypipes added a commit to aws/amazon-vpc-cni-k8s that referenced this issue Jan 31, 2020
@jaypipes
do pre-checks before creating EKS test cluster
d1f44b1 
Ensure that there is an ECR repo before we use aws-k8s-tester to actually
create the test cluster. In addition, trap errors in the main
run-integration-tests.sh script and deprovision cluster if an error
occurred after creating the cluster.

Updates the required aws-k8s-tester release to 0.5.2 to handle
aws/aws-k8s-tester#66

Issue #765

(cherry picked from commit 45a3719)
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Apr 20, 2020
@jaypipes
do pre-checks before creating EKS test cluster
7b3b00d 
Ensure that there is an ECR repo before we use aws-k8s-tester to actually
create the test cluster. In addition, trap errors in the main
run-integration-tests.sh script and deprovision cluster if an error
occurred after creating the cluster.

Updates the required aws-k8s-tester release to 0.5.2 to handle
aws/aws-k8s-tester#66

Issue aws#765
mogren pushed a commit to aws/amazon-vpc-cni-k8s that referenced this issue Apr 20, 2020
@jaypipes @mogren
do pre-checks before creating EKS test cluster
f6419c9 
Ensure that there is an ECR repo before we use aws-k8s-tester to actually
create the test cluster. In addition, trap errors in the main
run-integration-tests.sh script and deprovision cluster if an error
occurred after creating the cluster.

Updates the required aws-k8s-tester release to 0.5.2 to handle
aws/aws-k8s-tester#66

Issue #765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaypipes