Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revamping attrs-controlled class tests #33

Merged
merged 9 commits into from
Dec 5, 2017
Merged

revamping attrs-controlled class tests #33

merged 9 commits into from
Dec 5, 2017

Conversation

mattsb42-aws
Copy link
Member

Bugfixes

Maintenance

Also currently blacklisting attrs 17.3.0. That may be changing, but I wanted to get this out for review while I consider what to do about that. python-attrs/attrs#303 (comment)

@mattsb42-aws mattsb42-aws requested a review from a team December 4, 2017 19:45
…n __attrs_post_init__ and in MasterKey __new__ to work around limitations python-attrs/attrs#303
Copy link
Contributor

@lizroth lizroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all seem sensible to me, but I don't think I have a complete understanding of the underlying issue and surrounding concerns. If you feel confident in this change, great; otherwise, you might want to pull in one more reviewer to double check me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants