Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attrs 17.3.0 breaks some of our tests #29

Closed
mattsb42-aws opened this issue Nov 25, 2017 · 2 comments
Closed

attrs 17.3.0 breaks some of our tests #29

mattsb42-aws opened this issue Nov 25, 2017 · 2 comments
Assignees
Labels

Comments

@mattsb42-aws
Copy link
Member

Problem

The backwards incompatible change in attrs 17.3.0 broke some of our tests. This is apparently due to our use of a feature that was deprecated in 16.1.

Solution

The good news is that none of our actual client code uses this deprecated feature, so users should not be affected by this. Because of this, we just need to update our affected tests to move away from this access pattern.

@mattsb42-aws
Copy link
Member Author

While I will be fixing these tests, we may also need to blacklist attrs==17.3.0: python-attrs/attrs#303

@mattsb42-aws
Copy link
Member Author

To wrap up this issue, in #33 I fixed both problems identified above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant