Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Integrate ESDK-Java with AWS Cryptographic Material Providers Library (MPL) for Keyring and CMM Support. #1864

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

imabhichow
Copy link
Contributor

@imabhichow imabhichow commented Nov 21, 2023

Issue #, if available:

Description of changes:

  • New Features:
    The AWS ESDK for Java now incorporates the AWS Cryptographic Material Providers Library (MPL), enabling the use of Keyrings and Cryptographic Materials Managers (CMMs).

  • BREAKING CHANGE:
    This feature update includes a breaking change that requires AWS SDK v2 Java as a hard dependency.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@imabhichow imabhichow requested a review from a team as a code owner November 21, 2023 22:10
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just wondering about the submodule.

submodules/MaterialProviders Outdated Show resolved Hide resolved
…Library (MPL) for Keyring and CMM Support.

New Features:
The AWS ESDK for Java now incorporates  the AWS Cryptographic Material Providers Library (MPL), enabling the use of Keyrings and Cryptographic Materials Managers (CMMs).

BREAKING CHANGE:
This feature update includes a breaking change that requires AWS SDK v2 Java as a hard dependency.
kessplas
kessplas previously approved these changes Dec 5, 2023
pom.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@imabhichow imabhichow merged commit 9297e1b into master Dec 5, 2023
28 checks passed
aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Dec 6, 2023
## [3.0.0](v2.4.1...v3.0.0) (2023-12-06)

### ⚠ BREAKING CHANGES

* This feature update includes a breaking change that requires AWS SDK v2 Java as a hard dependency.

### Features

* Integrate ESDK-Java with AWS Cryptographic Material Providers Library (MPL) for Keyring and CMM Support. ([#1864](#1864)) ([9297e1b](9297e1b))

### Maintenance

* **CFN:** remove unused policy ([#1862](#1862)) ([43e078a](43e078a))
* **CFN:** update CFN stack to add managed policies to ci and release role ([#1856](#1856)) ([64c970f](64c970f))
* **deps:** bump org.apache.commons:commons-lang3 from 3.12.0 to 3.13.0 ([#1717](#1717)) ([ec41ae2](ec41ae2))
* fix release script ([#1796](#1796)) ([3617210](3617210))
* fix release-ci ([#1883](#1883)) ([92f29d0](92f29d0))
* **tests:** update ESDK tests to replace sun.security.* API ([#1852](#1852)) ([ca4c763](ca4c763))
* update release process ([#1888](#1888)) ([f222462](f222462))
* update the javadoc release script ([#1857](#1857)) ([1870a08](1870a08))
@imabhichow imabhichow deleted the mpl-integration branch December 11, 2023 03:47
@@ -515,6 +694,11 @@ public <K extends MasterKey<K>> CryptoResult<byte[], K> decryptData(
SignaturePolicy.AllowEncryptAllowDecrypt,
maxEncryptedDataKeys_);

return decryptData(cryptoHandler, ciphertext);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these deprecations documented anywhere?
The javadoc doesn't say anything about what should be used instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants