Skip to content

Commit

Permalink
chore(tests): update ESDK tests to replace sun.security.* API (#1852)
Browse files Browse the repository at this point in the history
Update ESDK Java tests to replace sun.security.* API with supported alternate API
  • Loading branch information
imabhichow authored Nov 16, 2023
1 parent 3617210 commit ca4c763
Showing 1 changed file with 23 additions and 32 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,26 +32,18 @@
import java.security.KeyStore.PasswordProtection;
import java.security.KeyStoreException;
import java.security.SecureRandom;
import java.security.Security;
import java.security.cert.Certificate;
import java.security.cert.X509Certificate;
import java.time.Instant;
import java.time.temporal.ChronoUnit;
import java.util.Date;
import javax.crypto.spec.SecretKeySpec;
import javax.security.auth.x500.X500Principal;
import org.bouncycastle.jce.provider.BouncyCastleProvider;
import org.bouncycastle.x509.X509V3CertificateGenerator;
import org.junit.Before;
import org.junit.Test;
import sun.security.x509.AlgorithmId;
import sun.security.x509.CertificateAlgorithmId;
import sun.security.x509.CertificateSerialNumber;
import sun.security.x509.CertificateValidity;
import sun.security.x509.CertificateX509Key;
import sun.security.x509.X500Name;
import sun.security.x509.X509CertImpl;
import sun.security.x509.X509CertInfo;

/* These internal sun classes are included solely for test purposes as
this test cannot use BouncyCastle cert generation, as there are incompatibilities
between how standard BC and FIPS BC perform cert generation. */

public class KeyStoreProviderTest {
private static final SecureRandom RND = new SecureRandom();
Expand All @@ -72,6 +64,7 @@ public class KeyStoreProviderTest {

@Before
public void setup() throws Exception {
Security.addProvider(new BouncyCastleProvider());
ks = KeyStore.getInstance(KeyStore.getDefaultType());
ks.load(null, PASSWORD);
}
Expand Down Expand Up @@ -286,26 +279,24 @@ private void addPublicEntry(final String alias) throws GeneralSecurityException,
}

private X509Certificate generateCertificate(final KeyPair pair, final String alias)
throws GeneralSecurityException, IOException {
final X509CertInfo info = new X509CertInfo();
final X500Name name = new X500Name("dc=" + alias);
info.set(X509CertInfo.SERIAL_NUMBER, new CertificateSerialNumber(new BigInteger(256, RND)));
info.set(X509CertInfo.SUBJECT, name);
info.set(X509CertInfo.ISSUER, name);
info.set(
X509CertInfo.VALIDITY,
new CertificateValidity(
Date.from(Instant.now().minus(1, ChronoUnit.DAYS)),
Date.from(Instant.now().plus(730, ChronoUnit.DAYS))));
info.set(X509CertInfo.KEY, new CertificateX509Key(pair.getPublic()));
info.set(
X509CertInfo.ALGORITHM_ID,
new CertificateAlgorithmId(new AlgorithmId(AlgorithmId.sha256WithRSAEncryption_oid)));

final X509CertImpl cert = new X509CertImpl(info);
cert.sign(pair.getPrivate(), AlgorithmId.sha256WithRSAEncryption_oid.toString());

return cert;
throws GeneralSecurityException {
final X509Certificate certificate;

// Generate self-signed certificate
final X509V3CertificateGenerator certGen = new X509V3CertificateGenerator();
final X500Principal dnName = new X500Principal("dc=" + alias);

certGen.setSerialNumber(new BigInteger(256, new SecureRandom()));
certGen.setIssuerDN(dnName);
certGen.setNotBefore(Date.from(Instant.now().minus(1, ChronoUnit.DAYS)));
certGen.setNotAfter(Date.from(Instant.now().plus(730, ChronoUnit.DAYS)));
certGen.setSubjectDN(dnName);
certGen.setPublicKey(pair.getPublic());
certGen.setSignatureAlgorithm("SHA256WithRSA");

certificate = certGen.generate(pair.getPrivate());

return certificate;
}

private void copyPublicPart(final KeyStore src, final KeyStore dst, final String alias)
Expand Down

0 comments on commit ca4c763

Please sign in to comment.