updating CommentIgnoringArgumentParser line parsing to behave properly in non-POSIX environments #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y in non-POSIX environments
lizroth
reviewed
Nov 17, 2017
| @@ -41,6 +42,7 @@ def __init__(self, *args, **kwargs): | |||
| # I would rather not duplicate the typeshed's effort keeping it up to date. | |||
| # https://github.com/python/typeshed/blob/master/stdlib/2and3/argparse.pyi#L27-L39 | |||
| self.__dummy_arguments = [] | |||
| self.__is_posix = os.name == 'posix' | |||
There was a problem hiding this comment.
I think this might do funny things with Jython? I think platform.win32_ver() might do the trick?
There was a problem hiding this comment.
Agreed. Switching to platform.win32_ver()
…() to detect inverse (no win32 version means POSIX)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating CommentIgnoringArgumentParser line parsing to behave properly in non-POSIX environments #78
Testing works in theory, but hold off merging until juneb@ has verified in an actual Windows environment.