Failing with --input parameter in config file

[juneb]

Is the input parameter permitted in config files?

Using aws-encryption-sdk-cli/1.0.2.3 aws-encryption-sdk/1.3.2 on Windows 10.0.14393.1770, PS 5.1.14393.1770

I have a config file, encrypt.conf, with the following contents:

--encrypt
--input .\TestCLI\Hello.txt
--output .\TestEnc
-S
@cmk.conf  #Includes a CMK ID, not ARN

When I run it, the command fails because it can't parse the input parameter in the file.

(py) PS C:\ps-test> aws-crypto `@encrypt.conf
Invalid source.  Must be a valid pathname pattern or stdin (-)

I created another config file, encrypt-no-i.conf, with the same content, except that I omitted the input parameter.

(py) PS C:\ps-test> cat .\encrypt-no-i.conf
--encrypt
--output .\TestEnc
-S
@cmk.conf

Then, I copied the --input parameter from the encrypt.conf file and added it, unchanged, to the command line. This command succeeds. (Overwrite is expected.)

(py) PS C:\ps-test> aws-crypto `@encrypt-no-i.conf --input .\TestCLI\Hello.txt
2017-11-15 08:43:16,765 - MainThread - aws_encryption_sdk_cli - WARNING - Overwriting existing target file because no action was specified otherwise: .TestEnc

I thought it might be a problem with the relative path in Windows, so I created a config file with the fully-qualified input path. I also tried a directory as the input arg + --recursive. That failed, too.

[mattsb42-aws]

Interesting. In poking at this offline with @juneb it looks like shlex is squashing \ characters. I'll look into making sure the shlex.escape characters are kept platform-correct.

https://docs.python.org/3/library/shlex.html

[mattsb42-aws]

Looks like we can fix this by simply turning off shlex's POSIX mode when not in a POSIX environment:

>>> import shlex
>>> shlex.split('--input .\TestCLI\Hello.txt')
['--input', '.TestCLIHello.txt']
>>> shlex.split('--input .\TestCLI\Hello.txt', posix=False)
['--input', '.\\TestCLI\\Hello.txt']

[juneb]

Verified that Windows paths in the --input, --output, and --metadata-output parameters are being interpreted correctly. The commands that failed before this fix now succeed.

However, environment variables in config files are not being expanded. #89