Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate aws-cdk from nodeunit to jest #5659

Merged
merged 1 commit into from
Jan 6, 2020

Commits on Jan 6, 2020

  1. chore: migrate aws-cdk from nodeunit to jest

    There is some interesting magic happening around the runtime-info
    module: `jest` replaces the standard `require` function so it can honor
    module mocking requirements, however this does (intentionally) not
    implement `require.cache`, which is used to determine which CDK
    libraries are loaded during a particular execution (in order to populate
    the `AWS::CDK::Metadata` resource as needed).
    
    In order to work around this, the `require.cache` reading was indirected
    through a proxy module, so it can be stubbed, too, with a pretend cache
    content, in order to make the test still workable.
    RomainMuller committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    9d88ca2 View commit details
    Browse the repository at this point in the history