chore: migrate aws-cdk from nodeunit to jest #5659
Merged
+2,714
−3,056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some interesting magic happening around the runtime-info module: `jest` replaces the standard `require` function so it can honor module mocking requirements, however this does (intentionally) not implement `require.cache`, which is used to determine which CDK libraries are loaded during a particular execution (in order to populate the `AWS::CDK::Metadata` resource as needed). In order to work around this, the `require.cache` reading was indirected through a proxy module, so it can be stubbed, too, with a pretend cache content, in order to make the test still workable.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
reviewed
Jan 6, 2020
| @@ -103,5 +99,23 @@ | |||
| "engines": { | |||
| "node": ">= 10.3.0" | |||
| }, | |||
| "stability": "stable" | |||
| "stability": "stable", | |||
There was a problem hiding this comment.
Why do we need this duplicated configuration everywhere? For example the reporter types should be the same for all modules!
eladb
approved these changes
Jan 6, 2020
|
Thank you for contributing! Your pull request is now being automatically merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some interesting magic happening around the runtime-info
module:
jestreplaces the standardrequirefunction so it can honormodule mocking requirements, however this does (intentionally) not
implement
require.cache, which is used to determine which CDKlibraries are loaded during a particular execution (in order to populate
the
AWS::CDK::Metadataresource as needed).In order to work around this, the
require.cachereading was indirectedthrough a proxy module, so it can be stubbed, too, with a pretend cache
content, in order to make the test still workable.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license