chore(cli-integ): optionally acquire environments from the cdk allocation service #33069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/small
iliapolo
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
iliapolo
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
iliapolo
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
iliapolo
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
iliapolo
changed the title
iliapolo
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33069 +/- ##
=======================================
Coverage 80.78% 80.78%
=======================================
Files 232 232
Lines 14111 14111
Branches 2453 2453
=======================================
Hits 11400 11400
Misses 2431 2431
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-maintainer-review
iliapolo
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
iliapolo
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
iliapolo
added
pr-linter/cli-integ-tested
iliapolo
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
approved these changes
Jan 27, 2025
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32437
Reason for this change
In preparation for migrating the integration tests to use the new allocation service. Once the service is deployed, we can set its endpoint in our codebuild jobs environment and thats it.
Description of changes
Introduce an environment variable
CDK_INTEG_ATMOSPHERE_ENABLED. When it evaluates to true, the integration tests will perform a request to the allocation service (using its dedicated client, added as a new dependency).Description of how you validated changes
Ran against a service instance deployed onto a personal account.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license