Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: allow runtime toggling between environment allocation mechanisms #32437

Closed
iliapolo opened this issue Dec 9, 2024 · 1 comment · Fixed by #33069
Closed

cli: allow runtime toggling between environment allocation mechanisms #32437

iliapolo opened this issue Dec 9, 2024 · 1 comment · Fixed by #33069
Assignees
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI

Comments

@iliapolo
Copy link
Contributor

iliapolo commented Dec 9, 2024

Once we have #31938, we should be able to switch between the current mechanism and the new service at runtime (e.g via environment variable).

@iliapolo iliapolo added the feature-request A feature should be added or improved. label Dec 9, 2024
@iliapolo iliapolo added this to the Environment Allocation Service | Phase 3 milestone Dec 9, 2024
@iliapolo iliapolo self-assigned this Dec 9, 2024
@iliapolo iliapolo removed this from the Environment Allocation Service | Phase 3 milestone Dec 17, 2024
@iliapolo iliapolo changed the title integ-testing: runtime allocation mechanism toggles cli: allow runtime toggling between environment allocation mechanisms Dec 17, 2024
@iliapolo iliapolo added package/tools Related to AWS CDK Tools or CLI p1 effort/small Small work item – less than a day of effort labels Dec 17, 2024
@mergify mergify bot closed this as completed in #33069 Jan 27, 2025
mergify bot pushed a commit that referenced this issue Jan 27, 2025
…tion service (#33069)

Closes #32437

### Reason for this change

In preparation for migrating the integration tests to use the new allocation service. Once the service is deployed, we can set its endpoint in our codebuild jobs environment and thats it.

### Description of changes

Introduce an environment variable `CDK_INTEG_ATMOSPHERE_ENABLED`. When it evaluates to true, the integration tests will perform a request to the allocation service (using its dedicated client, added as a new dependency).

### Description of how you validated changes

Ran against a service instance deployed onto a personal account.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2025
mazyu36 pushed a commit to mazyu36/aws-cdk that referenced this issue Jan 28, 2025
…tion service (aws#33069)

Closes aws#32437

### Reason for this change

In preparation for migrating the integration tests to use the new allocation service. Once the service is deployed, we can set its endpoint in our codebuild jobs environment and thats it.

### Description of changes

Introduce an environment variable `CDK_INTEG_ATMOSPHERE_ENABLED`. When it evaluates to true, the integration tests will perform a request to the allocation service (using its dedicated client, added as a new dependency).

### Description of how you validated changes

Ran against a service instance deployed onto a personal account.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 pushed a commit to mazyu36/aws-cdk that referenced this issue Jan 28, 2025
…tion service (aws#33069)

Closes aws#32437

### Reason for this change

In preparation for migrating the integration tests to use the new allocation service. Once the service is deployed, we can set its endpoint in our codebuild jobs environment and thats it.

### Description of changes

Introduce an environment variable `CDK_INTEG_ATMOSPHERE_ENABLED`. When it evaluates to true, the integration tests will perform a request to the allocation service (using its dedicated client, added as a new dependency).

### Description of how you validated changes

Ran against a service instance deployed onto a personal account.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant