-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: allow runtime toggling between environment allocation mechanisms #32437
Labels
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p1
package/tools
Related to AWS CDK Tools or CLI
Comments
iliapolo
changed the title
integ-testing: runtime allocation mechanism toggles
cli: allow runtime toggling between environment allocation mechanisms
Dec 17, 2024
This was referenced Dec 17, 2024
iliapolo
added
package/tools
Related to AWS CDK Tools or CLI
p1
effort/small
Small work item – less than a day of effort
labels
Dec 17, 2024
This was referenced Jan 1, 2025
1 task
mergify bot
pushed a commit
that referenced
this issue
Jan 27, 2025
…tion service (#33069) Closes #32437 ### Reason for this change In preparation for migrating the integration tests to use the new allocation service. Once the service is deployed, we can set its endpoint in our codebuild jobs environment and thats it. ### Description of changes Introduce an environment variable `CDK_INTEG_ATMOSPHERE_ENABLED`. When it evaluates to true, the integration tests will perform a request to the allocation service (using its dedicated client, added as a new dependency). ### Description of how you validated changes Ran against a service instance deployed onto a personal account. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Comments on closed issues and PRs are hard for our team to see. |
mazyu36
pushed a commit
to mazyu36/aws-cdk
that referenced
this issue
Jan 28, 2025
…tion service (aws#33069) Closes aws#32437 ### Reason for this change In preparation for migrating the integration tests to use the new allocation service. Once the service is deployed, we can set its endpoint in our codebuild jobs environment and thats it. ### Description of changes Introduce an environment variable `CDK_INTEG_ATMOSPHERE_ENABLED`. When it evaluates to true, the integration tests will perform a request to the allocation service (using its dedicated client, added as a new dependency). ### Description of how you validated changes Ran against a service instance deployed onto a personal account. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36
pushed a commit
to mazyu36/aws-cdk
that referenced
this issue
Jan 28, 2025
…tion service (aws#33069) Closes aws#32437 ### Reason for this change In preparation for migrating the integration tests to use the new allocation service. Once the service is deployed, we can set its endpoint in our codebuild jobs environment and thats it. ### Description of changes Introduce an environment variable `CDK_INTEG_ATMOSPHERE_ENABLED`. When it evaluates to true, the integration tests will perform a request to the allocation service (using its dedicated client, added as a new dependency). ### Description of how you validated changes Ran against a service instance deployed onto a personal account. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p1
package/tools
Related to AWS CDK Tools or CLI
Once we have #31938, we should be able to switch between the current mechanism and the new service at runtime (e.g via environment variable).
The text was updated successfully, but these errors were encountered: