Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appsync): add L2 constructs for AWS AppSync Events #32505

Merged
merged 66 commits into from
Jan 31, 2025

Conversation

kwwendt
Copy link
Contributor

@kwwendt kwwendt commented Dec 13, 2024

Issue # (if applicable)

Closes #32004

Reason for this change

This is in support of AWS AppSync Events.

Description of changes

  • New constructs for EventApi and ChannelNamespace to support AWS AppSync Events.
  • Create common file for authorization config across EventApi and GraphqlApi constructs.
  • Create common file for common resources across EventApi and GraphqlApi constructs.

Description of how you validated changes

Added both unit and integration tests for AWS AppSync Event API changes.

Contributors

@mazyu36 @onlybakam @kwwendt

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Dec 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 13, 2024 03:10
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Dec 13, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@kwwendt kwwendt changed the title feat(appsync): Add L2 constructs for AWS AppSync Events feat(appsync): add L2 constructs for AWS AppSync Events Dec 13, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 13, 2024 03:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed GavinZZ’s stale review January 30, 2025 22:28

Pull request has been modified.

GavinZZ
GavinZZ previously approved these changes Jan 30, 2025
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the effort and addressing our comments!

Copy link
Contributor

mergify bot commented Jan 30, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 31, 2025
Copy link
Contributor

mergify bot commented Jan 31, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@GavinZZ GavinZZ added the pr-linter/exempt-codecov The PR linter will not require codecov checks to pass label Jan 31, 2025
@GavinZZ
Copy link
Contributor

GavinZZ commented Jan 31, 2025

@mergify update

Copy link
Contributor

mergify bot commented Jan 31, 2025

update

✅ Branch has been successfully updated

@mergify mergify bot dismissed GavinZZ’s stale review January 31, 2025 19:38

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 21c4b72
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 31, 2025
Copy link
Contributor

mergify bot commented Jan 31, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jan 31, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@GavinZZ
Copy link
Contributor

GavinZZ commented Jan 31, 2025

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Jan 31, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 31, 2025
Copy link
Contributor

mergify bot commented Jan 31, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@GavinZZ
Copy link
Contributor

GavinZZ commented Jan 31, 2025

@mergify update

Copy link
Contributor

mergify bot commented Jan 31, 2025

update

☑️ Nothing to do

  • queue-position = -1 [📌 update requirement]
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

Copy link
Contributor

mergify bot commented Jan 31, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@GavinZZ GavinZZ merged commit 9ae1d34 into aws:main Jan 31, 2025
26 of 28 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2025
@GavinZZ GavinZZ self-assigned this Jan 31, 2025
@kwwendt kwwendt deleted the appsync-events branch February 3, 2025 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-security-review Related to feature or issues that needs security review p1 pr-linter/exempt-codecov The PR linter will not require codecov checks to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appsync: L2 for AppSync Events
7 participants