feat(appsync): support AppSync Events #32411
Conversation
github-actions
bot
added
effort/medium
github-actions
bot
added
the
distinguished-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32411 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 107 107
Lines 7237 7237
Branches 1329 1329
=======================================
Hits 5693 5693
Misses 1358 1358
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mazyu36
changed the title
mazyu36
changed the title
mazyu36
force-pushed
the
appsync-event-api
branch
from
3d49732 to
1627bfb
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| /** | ||
| * enum with all possible values for AppSync authorization type | ||
| */ | ||
| export enum AuthorizationType { |
There was a problem hiding this comment.
The authorization config is largely same between GraphQL and Events, so it has been extracted into a separate file.
| public readonly channelNamespaceArn: string; | ||
|
|
||
| constructor(scope: Construct, id: string, props: ChannelNamespaceProps) { | ||
| if (props.channelNamespaceName !== undefined && !Token.isUnresolved(props.channelNamespaceName)) { |
There was a problem hiding this comment.
ChannelNamespaceName's pattern is quoted from Management Console.
Currently, this pattern is inconsistent with the one described in the CloudFormation documentation.
I've reported it. aws-cloudformation/cloudformation-coverage-roadmap#2208
mazyu36
changed the title
aws-cdk-automation
added
the
pr/needs-maintainer-review
aws-cdk-automation
removed
the
pr/needs-maintainer-review
mazyu36
force-pushed
the
appsync-event-api
branch
from
d96d832 to
ae572a3
Compare
|
hey @mazyu36, thanks for opening this PR. the AppSync team is working on an L2 implementation as well. It would be good to collaborate and merge some of those efforts. Let me know if you're open to that and we can connect. |
aws-cdk-automation
added
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you. |
|
cool. can you email me at |
|
Since I am currently collaborating with the AppSync team, this PR will remain in Draft status for the time being. |
wow ! I can't wait to see this, is any schedule about release? I'm considering how to do implementation for AppSnyc Events in our code base, if L2 construct ready will be so much helpful ! |
|
@tai-acall Please be patient for a moment. |
|
New PR by AppSync Team is now opened. So I close this PR. |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #32004.
Reason for this change
To support AppSync Event APIs.
Description of changes
Add
ApiandChannelNamespaceConstruct.Description of how you validated changes
Add unit tests and an integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license