feat(core): add Tokenization.isResolvable for aspects

packages/@aws-cdk/aws-s3/test/test.aspect.ts

@@ -0,0 +1,52 @@
+// import { expect, haveResource, haveResourceLike, SynthUtils } from '@aws-cdk/assert';
+import { SynthUtils } from '@aws-cdk/assert';
+import cdk = require('@aws-cdk/core');
+import { Stack, Tokenization } from '@aws-cdk/core';
+import { Test } from 'nodeunit';
+import s3 = require('../lib');
+
+export = {
+  'bucket must have versioning: failure'(test: Test) {
+    // GIVEN
+    const stack = new Stack();
+    new s3.Bucket(stack, 'MyBucket');
+
+    // WHEN
+    stack.node.applyAspect(new BucketVersioningChecker());
+
+    // THEN
+    const assembly = SynthUtils.synthesize(stack);
+    const errorMessage = assembly.messages.find(m => m.entry.data === 'Bucket versioning is not enabled');
+    test.ok(errorMessage, 'Error message not reported');
+
+    test.done();
+  },
+
+  'bucket must have versioning: success'(test: Test) {
+    // GIVEN
+    const stack = new Stack();
+    new s3.Bucket(stack, 'MyBucket', {
+      versioned: true
+    });
+
+    // WHEN
+    stack.node.applyAspect(new BucketVersioningChecker());
+
+    // THEN
+    const assembly = SynthUtils.synthesize(stack);
+    test.deepEqual(assembly.messages, []);
+
+    test.done();
+  },
+};
+
+class BucketVersioningChecker implements cdk.IAspect {
+  public visit(node: cdk.IConstruct): void {
+    if (node instanceof s3.CfnBucket) {
+      if (!node.versioningConfiguration ||
+        (!Tokenization.isResolvable(node.versioningConfiguration) && node.versioningConfiguration.status !== 'Enabled')) {
+        node.node.addError('Bucket versioning is not enabled');
+      }
+    }
+  }
+}

packages/@aws-cdk/core/lib/token.ts

@@ -114,6 +114,17 @@ export class Tokenization {
     return resolve(obj, options);
   }
 
+  /**
+   * Return whether the given object is an IResolvable object
+   *
+   * This is different from Token.isUnresolved() which will also check for
+   * encoded Tokens, whereas this method will only do a type check on the given
+   * object.
+   */
+  public static isResolvable(obj: any): obj is IResolvable {
+    return isResolvableObject(obj);
+  }
+
   private constructor() {
   }
 }