Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add Tokenization.isResolvable for aspects #3122

Merged
merged 1 commit into from
Jun 30, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 28, 2019

Add an example of a validating aspect, add Tokenization.isResolvable()
to make it easier/possible to rule out IResolvables from L1
properties.

Included unit tests validates that the bug reported in #3026 is not systemic.


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add an example of a validating aspect, add `Tokenization.isResolvable()`
to make it easier/possible to rule out `IResolvable`s from L1
properties.

Included unit tests  validates that the bug reported in #3026 is not systemic.
@rix0rrr rix0rrr requested a review from a team as a code owner June 28, 2019 09:51
@ghost ghost requested a review from skinny85 June 28, 2019 09:52
@eladb eladb merged commit d3a417e into master Jun 30, 2019
@RomainMuller RomainMuller deleted the huijbers/validating-aspect branch August 10, 2019 00:39
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants