fix(eks): add correct helm asset snapshot #30835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
TheRealAmazonKendra
requested changes
Jul 12, 2024
| @@ -118,15 +118,15 @@ | |||
| } | |||
| } | |||
| }, | |||
| "87e05e7e56d00f8bd9133b97480ff01b622c9f7f500f8544cef311a412454395": { | |||
| "0ab01c1684677dce72948d48cdd47d31aef3137c741b066737be81fe5944e6fe": { | |||
There was a problem hiding this comment.
This asset hash update means that there should also be changes to the asset files. At the very least, they should be renamed.
|
closing this one as snapshots are updated in this PR |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #
Reason for this change
PR##29454 introduced incorrect snapshot changes for the helm asset.
Description of changes
Modified helm asset integration test file to add below flag as part of existing chart installation('rds-chart-release')
atomic: trueDescription of how you validated changes
Successful deployment for integration test
integ.eks-helm-asset.tsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license