Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eks): update failing snapshots #30829

Merged
merged 3 commits into from
Jul 24, 2024
Merged

chore(eks): update failing snapshots #30829

merged 3 commits into from
Jul 24, 2024

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Jul 11, 2024 •
edited
Loading

update framework-integ/test/aws-eks/test/integ.eks-helm-asset.ts that might fail in some cases:

  1. set aws.region for the helm charts to ensure successful helm deployment
  2. make sure each helm charts assertion use different chart source to avoid conflict
  3. update the snapshots

Issue # (if applicable)

Closes #.

Reason for this change

Description of changes

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jul 11, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 11, 2024 17:51
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 11, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 11, 2024
@github-actions github-actions bot mentioned this pull request Jul 15, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 23, 2024
@shikha372 shikha372 mentioned this pull request Jul 23, 2024
Closed
1 task
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7eb771a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7b2a653 into aws:main Jul 24, 2024
9 checks passed
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

obraafo pushed a commit to obraafo/aws-cdk that referenced this pull request Jul 25, 2024
@pahud
chore(eks): update failing snapshots (aws#30829)
e5fd699 
update `framework-integ/test/aws-eks/test/integ.eks-helm-asset.ts` that might fail in some cases:

1. set `aws.region` for the helm charts to ensure successful helm deployment
2. make sure each helm charts assertion use different chart source to avoid conflict
3. update the snapshots

### Issue # (if applicable)

Closes #<issue number here>.

### Reason for this change



### Description of changes



### Description of how you validated changes



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GavinZZ GavinZZ GavinZZ approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pahud @aws-cdk-automation @GavinZZ