Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-resources): log statement exposes information prohibited by security guideline #29406

Merged
merged 10 commits into from
Mar 8, 2024
Merged

fix(custom-resources): log statement exposes information prohibited by security guideline #29406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3d36769
fix(custom-resources): log statement exposes presigned s3 url
GavinZZ Mar 8, 2024
b3ab5fa
Remove input from log event
GavinZZ Mar 8, 2024
672107c
update global-replicas test case
GavinZZ Mar 8, 2024
6f95e7d
Update integ.provider test
GavinZZ Mar 8, 2024
1b8ce07
Update lambda-layer-awscli-integ test
GavinZZ Mar 8, 2024
755b47a
Update lambda-layer-kubectl test
GavinZZ Mar 8, 2024
b75ef27
Update integ.global table test
GavinZZ Mar 8, 2024
3c81dab
Update rds cluster test
GavinZZ Mar 8, 2024
bd3b02a
Fix amplify tests
GavinZZ Mar 8, 2024
3890834
Merge branch 'main' into yuanhaoz/remove_presign_url_log
paulhcsun Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
161 changes: 0 additions & 161 deletions ...pshot/asset.0bf2fcabaf8a17312250c937e09a95d38644ae45e5a534f6e36b821826b3f295/framework.js
View file
Open in desktop

This file was deleted.

0 ...5e5a534f6e36b821826b3f295/cfn-response.js → ...4e0b4395f114641a81cd52ae5/cfn-response.js
View file
Open in desktop
File renamed without changes.
0 ...644ae45e5a534f6e36b821826b3f295/consts.js → ...793c9c4e0b4395f114641a81cd52ae5/consts.js
View file
Open in desktop
File renamed without changes.
164 changes: 164 additions & 0 deletions ...pshot/asset.15197a5512179542fe2cff74af89bb047793c9c4e0b4395f114641a81cd52ae5/framework.js
View file
Open in desktop

Large diffs are not rendered by default.

0 ...4ae45e5a534f6e36b821826b3f295/outbound.js → ...3c9c4e0b4395f114641a81cd52ae5/outbound.js
View file
Open in desktop
File renamed without changes.
0 ...38644ae45e5a534f6e36b821826b3f295/util.js → ...47793c9c4e0b4395f114641a81cd52ae5/util.js
View file
Open in desktop
File renamed without changes.
14 changes: 7 additions & 7 deletions ...replicas-provisioned.js.snapshot/aws-cdk-dynamodb-global-replicas-provisioned.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...plicas-provisioned.js.snapshot/aws-cdk-dynamodb-global-replicas-provisioned.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@
{
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"/9b9001daf8f61286650547525632438d88f5da19960bffa81934912c947db820.json"
"/9e74695d20fbb89dc62fd8a020b6273050655fc292429f61f3ec014282a93e69.json"
]
]
}
Expand Down
6 changes: 3 additions & 3 deletions ...odbglobalreplicasprovisionedawscdkawsdynamodbReplicaProviderEA32CB30.nested.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "0bf2fcabaf8a17312250c937e09a95d38644ae45e5a534f6e36b821826b3f295.zip"
"S3Key": "15197a5512179542fe2cff74af89bb047793c9c4e0b4395f114641a81cd52ae5.zip"
},
"Description": "AWS CDK resource provider framework - onEvent (aws-cdk-dynamodb-global-replicas-provisioned/@aws-cdk--aws-dynamodb.ReplicaProvider/Provider)",
"Environment": {
Expand Down Expand Up @@ -441,7 +441,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "0bf2fcabaf8a17312250c937e09a95d38644ae45e5a534f6e36b821826b3f295.zip"
"S3Key": "15197a5512179542fe2cff74af89bb047793c9c4e0b4395f114641a81cd52ae5.zip"
},
"Description": "AWS CDK resource provider framework - isComplete (aws-cdk-dynamodb-global-replicas-provisioned/@aws-cdk--aws-dynamodb.ReplicaProvider/Provider)",
"Environment": {
Expand Down Expand Up @@ -575,7 +575,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "0bf2fcabaf8a17312250c937e09a95d38644ae45e5a534f6e36b821826b3f295.zip"
"S3Key": "15197a5512179542fe2cff74af89bb047793c9c4e0b4395f114641a81cd52ae5.zip"
},
"Description": "AWS CDK resource provider framework - onTimeout (aws-cdk-dynamodb-global-replicas-provisioned/@aws-cdk--aws-dynamodb.ReplicaProvider/Provider)",
"Environment": {
Expand Down
2 changes: 1 addition & 1 deletion ...-integ/test/aws-dynamodb/test/integ.global-replicas-provisioned.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...work-integ/test/aws-dynamodb/test/integ.global-replicas-provisioned.js.snapshot/tree.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

161 changes: 0 additions & 161 deletions ...pshot/asset.0bf2fcabaf8a17312250c937e09a95d38644ae45e5a534f6e36b821826b3f295/framework.js
View file
Open in desktop

This file was deleted.

0 ...5e5a534f6e36b821826b3f295/cfn-response.js → ...4e0b4395f114641a81cd52ae5/cfn-response.js
View file
Open in desktop
File renamed without changes.
0 ...644ae45e5a534f6e36b821826b3f295/consts.js → ...793c9c4e0b4395f114641a81cd52ae5/consts.js
View file
Open in desktop
File renamed without changes.
164 changes: 164 additions & 0 deletions ...pshot/asset.15197a5512179542fe2cff74af89bb047793c9c4e0b4395f114641a81cd52ae5/framework.js
View file
Open in desktop

Large diffs are not rendered by default.

0 ...4ae45e5a534f6e36b821826b3f295/outbound.js → ...3c9c4e0b4395f114641a81cd52ae5/outbound.js
View file
Open in desktop
File renamed without changes.
0 ...38644ae45e5a534f6e36b821826b3f295/util.js → ...47793c9c4e0b4395f114641a81cd52ae5/util.js
View file
Open in desktop
File renamed without changes.
14 changes: 7 additions & 7 deletions .../test/aws-dynamodb/test/integ.global.js.snapshot/cdk-dynamodb-global-20191121.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...est/aws-dynamodb/test/integ.global.js.snapshot/cdk-dynamodb-global-20191121.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@
{
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-eu-west-1"
},
"/c45bdec0bae4c26b8902084eb8316242c9eb164831a5431dad17fc5a4ac3e090.json"
"/4148c9473bcbd8c19e338a215d442b27cc755081d5d4980c0648dfd92306e0e5.json"
]
]
}
Expand Down
6 changes: 3 additions & 3 deletions ...ot/cdkdynamodbglobal20191121awscdkawsdynamodbReplicaProviderB281C954.nested.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-eu-west-1"
},
"S3Key": "0bf2fcabaf8a17312250c937e09a95d38644ae45e5a534f6e36b821826b3f295.zip"
"S3Key": "15197a5512179542fe2cff74af89bb047793c9c4e0b4395f114641a81cd52ae5.zip"
},
"Description": "AWS CDK resource provider framework - onEvent (cdk-dynamodb-global-20191121/@aws-cdk--aws-dynamodb.ReplicaProvider/Provider)",
"Environment": {
Expand Down Expand Up @@ -437,7 +437,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-eu-west-1"
},
"S3Key": "0bf2fcabaf8a17312250c937e09a95d38644ae45e5a534f6e36b821826b3f295.zip"
"S3Key": "15197a5512179542fe2cff74af89bb047793c9c4e0b4395f114641a81cd52ae5.zip"
},
"Description": "AWS CDK resource provider framework - isComplete (cdk-dynamodb-global-20191121/@aws-cdk--aws-dynamodb.ReplicaProvider/Provider)",
"Environment": {
Expand Down Expand Up @@ -571,7 +571,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-eu-west-1"
},
"S3Key": "0bf2fcabaf8a17312250c937e09a95d38644ae45e5a534f6e36b821826b3f295.zip"
"S3Key": "15197a5512179542fe2cff74af89bb047793c9c4e0b4395f114641a81cd52ae5.zip"
},
"Description": "AWS CDK resource provider framework - onTimeout (cdk-dynamodb-global-20191121/@aws-cdk--aws-dynamodb.ReplicaProvider/Provider)",
"Environment": {
Expand Down
2 changes: 1 addition & 1 deletion ...cdk-testing/framework-integ/test/aws-dynamodb/test/integ.global.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.global.js.snapshot/tree.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading