Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-resources): log statement exposes information prohibited by security guideline #29406

Merged
merged 10 commits into from
Mar 8, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Mar 8, 2024

Issue # (if applicable)

Reason for this change

Current log statement will log too much content, including response URL which may not be ideal to be logged according to AWS Security Guideline. Removing the input event from the log statement.

Description of changes

Remove the log statement.

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@GavinZZ GavinZZ marked this pull request as ready for review March 8, 2024 00:17
@aws-cdk-automation aws-cdk-automation requested a review from a team March 8, 2024 00:18
@github-actions github-actions bot added the p2 label Mar 8, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 8, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@GavinZZ
Copy link
Contributor Author

GavinZZ commented Mar 8, 2024

This seems to be a breaking change, will wrap it with a feature flag.

@TheRealAmazonKendra
Copy link
Contributor

Changes to the hash doesn't necessarily indicate a breaking change. I would pull this PR down and run those tests with --force --update-on-failed to see if there is actually an impact to the functionality or if it just changes the contents of those lambdas, which we would expect on a change like this.

@GavinZZ GavinZZ force-pushed the yuanhaoz/remove_presign_url_log branch from edc97f5 to 672107c Compare March 8, 2024 18:18
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 8, 2024 18:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@GavinZZ GavinZZ changed the title fix(custom-resources): log statement exposes presigned s3 url fix(custom-resources): log statement exposes information prohibited according to security guideline Mar 8, 2024
@GavinZZ GavinZZ changed the title fix(custom-resources): log statement exposes information prohibited according to security guideline fix(custom-resources): log statement exposes information prohibited by security guideline Mar 8, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 8, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3890834
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 11621e7 into main Mar 8, 2024
13 checks passed
@mergify mergify bot deleted the yuanhaoz/remove_presign_url_log branch March 8, 2024 22:00
mergify bot pushed a commit that referenced this pull request Sep 5, 2024
)

### Issue # (if applicable)

Closes #31320

### Reason for this change

Presigned url is still logged despite a previous PR to fix it. #29406

### Description of changes

Verified that the `events:` no longer display the response url.

### Description of how you validated changes

Re-run all failed integration tests

### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
pahud pushed a commit to pahud/aws-cdk that referenced this pull request Sep 9, 2024
…#31322)

### Issue # (if applicable)

Closes aws#31320

### Reason for this change

Presigned url is still logged despite a previous PR to fix it. aws#29406

### Description of changes

Verified that the `events:` no longer display the response url.

### Description of how you validated changes

Re-run all failed integration tests

### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
xazhao pushed a commit to xazhao/aws-cdk that referenced this pull request Sep 12, 2024
…#31322)

### Issue # (if applicable)

Closes aws#31320

### Reason for this change

Presigned url is still logged despite a previous PR to fix it. aws#29406

### Description of changes

Verified that the `events:` no longer display the response url.

### Description of how you validated changes

Re-run all failed integration tests

### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
GavinZZ added a commit that referenced this pull request Sep 12, 2024
)

### Issue # (if applicable)

Closes #31320

### Reason for this change

Presigned url is still logged despite a previous PR to fix it. #29406

### Description of changes

Verified that the `events:` no longer display the response url.

### Description of how you validated changes

Re-run all failed integration tests

### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants