Commits on Jun 7, 2019

1. fix(core): Make filterUndefined null-safe …

   There are a couple of places where fields accept values that are typed
   as `Json` per the JSII type specification. This conveys that literal
   `null` values may be passed and need to be preserved (as far as JSII is
   concerned - see aws/jsii#523). However in the CloudFormation domain,
   `null` is semantically equivalent to `undefined`.
   
   Now enters Javascript's confusing type system, where `null` is an
   `object` that cannot be converted to `object` (you read this correctly):
   
   ```js
   typeof null === 'object'
   // => true
   
   Object.entries(null);
   // => Thrown:
   //    TypeError: Cannot convert undefined or null to object
   //        at Function.entries (<anonymous>)
   ```
   
   So this changes the `undefined` checks to the `null`-coercing way, so
   that `null` and `undefined` are handled the same way.

   

   RomainMuller committed Jun 7, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 18875d5
   • Browse repository at this point

   Copy the full SHA

   18875d5 View commit details

   Browse the repository at this point in the history