fix(core): Make filterUndefined null-safe #2789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of places where fields accept values that are typed
as
Json
per the JSII type specification. This conveys that literalnull
values may be passed and need to be preserved (as far as JSII isconcerned - see aws/jsii#523). However in the CloudFormation domain,
null
is semantically equivalent toundefined
.Now enters Javascript's confusing type system, where
null
is anobject
that cannot be converted toobject
(you read this correctly):So this changes the
undefined
checks to thenull
-coercing way, sothat
null
andundefined
are handled the same way.Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.