Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): apply overrides after rendering properties #2685

Merged
merged 2 commits into from
May 30, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/@aws-cdk/cdk/lib/cfn-resource.ts
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,11 @@ export class CfnResource extends CfnRefElement {
Metadata: ignoreEmpty(this.options.metadata),
Condition: this.options.condition && this.options.condition.logicalId
}, props => {
const r = deepMerge(props, this.rawOverrides);
r.Properties = this.renderProperties(r.Properties);
return r;
// let derived classes to influence how properties are rendered (e.g. change capitalization)
props.Properties = this.renderProperties(props.Properties);

// merge overrides *after* rendering
return deepMerge(props, this.rawOverrides);
})
}
};
Expand Down
32 changes: 32 additions & 0 deletions packages/@aws-cdk/cdk/test/test.resource.ts
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,38 @@ export = {
test.done();
},

'overrides are applied after render'(test: Test) {
// GIVEN
class MyResource extends CfnResource {
public renderProperties() {
return { Fixed: 123 };
}
}
const stack = new Stack();
const cfn = new MyResource(stack, 'rr', { type: 'AWS::Resource::Type' });

// WHEN
cfn.addPropertyOverride('Boom', 'Hi');
cfn.addOverride('Properties.Foo.Bar', 'Bar');

// THEN
test.deepEqual(stack._toCloudFormation(), {
Resources: {
rr: {
Type: 'AWS::Resource::Type',
Properties: {
Fixed: 123,
Boom: 'Hi',
Foo: {
Bar: 'Bar'
}
}
}
}
});
test.done();
},

'untypedPropertyOverrides': {

'can be used by derived classes to specify overrides before render()'(test: Test) {
Expand Down