Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): apply overrides after rendering properties #2685

Merged
merged 2 commits into from
May 30, 2019
Merged

fix(core): apply overrides after rendering properties #2685

merged 2 commits into from
May 30, 2019

Commits on May 30, 2019

  1. fix(core): apply overrides after rendering properties 

    Resource overrides (`addOverride` and `addPropertyOverride`) should be
applied after rendering properties at the L1 level. Otherwise, validation
and capitalization changes would be applied to overrides and this
contradicts the idea of being able to specify arbitrary overrides as
"patches" to the synthesized resource.

The previous behavior had two adverse effects:
1. If a property was unknown, it would be omitted from the resource
2. Properties names would need to be capitalized in camel case instead of 1:1 with the CFN schema.

Fixes #2677

BREAKING CHANGE: Properties passed to `addPropertyOverride` should match in capitalization to the CloudFormation schema (normally pascal case). For example, `addPropertyOverride('accessControl', 'xxx')` should now be `addPropertyOverride('AccessControl', 'xxx')`.
    Elad Ben-Israel committed May 30, 2019
    Configuration menu
    Copy the full SHA
    b5f2a32 View commit details
    Browse the repository at this point in the history

  2. add an end-to-end for escape hatches to verify behavior.

    Elad Ben-Israel committed May 30, 2019
    Configuration menu
    Copy the full SHA
    42ce0d3 View commit details
    Browse the repository at this point in the history